Skip to content

Patch 2 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Patch 2 #56

wants to merge 4 commits into from

Conversation

dannylewis-sheffield
Copy link

Had to import Foundation and CryptoSwift to get 2.1.0 to build, so I've imported them and bumped the version in JSONWebToken.podspec

kylef
kylef reviewed Jan 20, 2017
View reviewed changes
Sources/ClaimSet.swift
@@ -1,3 +1,6 @@
import Foundation
import CryptoSwift
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that Foundation is required, but I don't think CryptoSwift should be. There is no use of CryptoSwift throughout this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've removed it

@kylef
Copy link
Owner

kylef commented Feb 17, 2017

I'm not able to reproduce any build problems on master with Swift 3.0.2. Are you able to reproduce the problem still?

$ swift --version
Apple Swift version 3.0.2 (swiftlang-800.0.63 clang-800.0.42.1)
Target: x86_64-apple-macosx10.9

$ swift test
...
Test Suite 'PayloadTests' passed at 2017-02-17 22:17:06.174.
	 Executed 6 tests, with 0 failures (0 unexpected) in 0.001 (0.001) seconds
Test Suite 'JWTPackageTests.xctest' passed at 2017-02-17 22:17:06.174.
	 Executed 36 tests, with 0 failures (0 unexpected) in 0.017 (0.019) seconds
Test Suite 'All tests' passed at 2017-02-17 22:17:06.174.
	 Executed 36 tests, with 0 failures (0 unexpected) in 0.017 (0.020) seconds

@kylef
Copy link
Owner

kylef commented Apr 24, 2017

Solved by b605fe2

@kylef kylef closed this Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylef kylef kylef left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannylewis-sheffield @kylef